[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning
Date: Thu, 23 May 2013 16:49:18 +0530

On (Tue) 21 May 2013 [17:32:57], Michael Roth wrote:
> When this VMSD was introduced it's version fields were set to
> sizeof(I6300State), making them essentially random from build to build,
> version to version.
> To fix this, we lock in a high version id and low minimum version id to
> support old->new migration from all prior versions of this device's
> state. This should work since the device state has not changed since
> its introduction.
> The potentially breaks migration from 1.5+ to 1.5, but since the
> versioning was essentially random prior to this patch, new->old
> migration was not consistently functional to begin with.
> Reported-by: Nicholas Thomas <address@hidden>
> Suggested-by: Peter Maydell <address@hidden>
> Cc: address@hidden
> Signed-off-by: Michael Roth <address@hidden>

Please fix the comment below per Laszlo's comment, and you can add:

Reviewed-by: Amit Shah <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]