[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while comp

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier
Date: Thu, 23 May 2013 14:12:29 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote:
> Add C++ keywords to avoid errors in compiling with c++ compiler.
> This also renames class member of PciDeviceInfo to q_class.
> Signed-off-by: Tomoki Sekiyama <address@hidden>
> ---
>  hmp.c           |    2 +-
>  hw/pci/pci.c    |    2 +-
>  scripts/qapi.py |    9 ++++++++-
>  3 files changed, 10 insertions(+), 3 deletions(-)

Please also extend scripts/checkpatch.pl.  Otherwise it is very likely
that C++ keywords will be introduced again in the future.  Most people
will not build the VSS code and therefore checkpatch.pl needs to ensure
that patches with C++ keywords will not be accepted.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]