[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event
Date: Thu, 23 May 2013 08:52:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
>>> Please stress this is only for the NIC. It does not apply
>>> to non-NIC netclients.
>> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit
>> generic.
> What do you suggest?

Yes, that might work.  (And whatever name we bikeshed, insert it in the
correct sorted order in the file)

>> Also, although I haven't reviewed the next patch yet, I think you
>> should move the event trigger to this patch.
> That's hard because of the flag that's shared with the query
> command.

It's fine if this patch declares and sets the flag, but the event is
one-shot until the next patch adds the query to clear the flag.  And
again, the flag should be per-device, not global.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]