[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty
Date: Thu, 23 May 2013 14:18:46 -0500
User-agent: Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)

Peter Maydell <address@hidden> writes:

> On 21 May 2013 11:57, Paolo Bonzini <address@hidden> wrote:
>> It is not used anywhere.
> So does this get deleted just because it's not used, or because
> it gets in the way of patches later in the series. As far as I
> can tell the st*_phys_notdirty() are for TCG to update page
> table entries with accessed/modified bits, and I don't see
> any reason we wouldn't have targets that need to update a
> 64 bit page table descriptor rather than just 32 bits of it.

Unused code is untested code.  Untested code is broken code.

Someone can add it back later if it's ever needed.

Reviewed-by: Anthony Liguori <address@hidden>


Anthony Liguori

> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]