[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

From: Richard W.M. Jones
Subject: Re: [Qemu-devel] [PATCH] Remove unnecessary break statements
Date: Fri, 24 May 2013 13:33:10 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

On Fri, May 24, 2013 at 12:19:25PM +0200, Stefan Weil wrote:
> Fix these warnings from cppcheck:
> hw/display/cirrus_vga.c:2603:
> hw/sd/sd.c:348:
> hw/timer/exynos4210_mct.c:1033:
> target-arm/translate.c:9886:
> target-s390x/mem_helper.c:518:
> target-unicore32/translate.c:1936:
>  style: Consecutive return, break, continue, goto or throw statements are 
> unnecessary.

I'm not sure what cppcheck does, but I spotted an unnecessary break
statement in the watchdog code a few days ago:

(line 131)

So it's obviously not finding them all :-(


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]