[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qmp commands get rejected

From: Stefan Priebe
Subject: Re: [Qemu-devel] qmp commands get rejected
Date: Sat, 25 May 2013 00:04:50 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6

Am 24.05.2013 23:37, schrieb Stefan Priebe:
Am 24.05.2013 17:21, schrieb Luiz Capitulino:
On Fri, 24 May 2013 16:36:26 +0200
Stefan Priebe - Profihost AG <address@hidden> wrote:

Am 24.05.2013 um 16:02 schrieb Luiz Capitulino

On Fri, 24 May 2013 15:57:59 +0200
Stefan Priebe - Profihost AG <address@hidden> wrote:

Am 24.05.2013 um 15:23 schrieb Luiz Capitulino

On Fri, 24 May 2013 07:50:33 +0200
Stefan Priebe <address@hidden> wrote:

Hello list,

since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp

With Qemu 1.5 i've the following socket communication:


'{"return": {}, "id": "12125:1"}'


'{"QMP": {"version": {"qemu": {"micro": 0, "minor": 5, "major": 1},
"package": ""}, "capabilities": []}}'

'{"id": "12125:2", "error": {"class": "CommandNotFound", "desc":
command qom-set has not been found"}}'

It seems that the command mode (qmp_capabilities) gets resets by
welcome banner?

It looks like you got disconnected before qom-set was issued.

No its the same socket connection. No disconnect had happened.

Can you share more details on how those commands are being issued?

They're send through socket with a perl script. What do you need?

That perl script maybe? I can't reproduce the problem.

I would try to create a small example script.

I use qmp-shell and other little scripts very often.

Am this be due to the fact that I don't wait for the welcome banner
right now?

If you're not reading from the socket, then you'll get the banner back
you read your first response. But qom-set shouldn't fail because of

I can workaround it by adding this patch:
diff --git a/monitor.c b/monitor.c
index 62aaebe..9997520 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4239,7 +4239,8 @@ static int monitor_can_read(void *opaque)
  static int invalid_qmp_mode(const Monitor *mon, const char *cmd_name)
      int is_cap = compare_cmd(cmd_name, "qmp_capabilities");
-    return (qmp_cmd_mode(mon) ? is_cap : !is_cap);
+//    return (qmp_cmd_mode(mon) ? is_cap : !is_cap);
+    return ((is_cap > 0) ? 0 : (qmp_cmd_mode(mon) ? is_cap : !is_cap));


It fixes it for the moment... but not in general. Still seeing failing commands...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]