Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Laszlo Ersek]

On 05/08/13 13:39, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <address@hidden>
> 
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
>    audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
> 

Shouldn't the default audio driver list ($audio_drv_list) be a subset of
the possible driver list?

Thanks,
Laszlo