[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build

From: Michael Tokarev
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI
Date: Sat, 25 May 2013 13:14:59 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0

24.05.2013 22:47, Brad Smith wrote:

>>> +++ b/include/qemu-common.h
>>>  #elif defined CONFIG_BSD
>>> +# include <termios.h>

> Kinda late nit picking about it now.

It's not.  And it's not nitpicking really, we're
carrying a ton of unnecessary #includes which slows
down compilation significantly.

The whole this piece of #include twist was to get
declaration of openpty() or equivalent.  You just
stiffed an unrelated #include into this piece which
was okay to remove completely.  I already removed
it from several other .c files where it went from
vl.c originally, which used to have chardev code
which is now in another file.

What was the original issue?  Where exactly it was
failing?  I mean, where's the _proper_ place to
fix it?

Speaking of "too late" -- it is definitely not late
to fix another bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]