[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when

From: li guang
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
Date: Mon, 27 May 2013 09:40:53 +0800

在 2013-05-25六的 14:42 +0400,Michael Tokarev写道:
> 25.05.2013 14:35, Andreas Färber wrote:
> > Am 25.05.2013 11:28, schrieb Michael Tokarev:
> []
> >>>    debugcon: use fprintf(stderr...) instead of printf
> >>
> >> The subjects and commit messages are a bit inaccurate, and
> >> as Andreas says, these may have been merged together, but
> >> the inaccuracy is small (and mostly due to language barriers),
> >> and the result is good anyway, with one patch doing one thing.
> >>
> >> So.. thanks, applied to the trivial-patches queue.
> > 
> > NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes
> > no sense as-is (just look at the stderr output to see what I mean) and
> > it pretends that I suggested that!
> Actually I did just that, rebuild with DEBUG_DEBUGCON and looked
> at the output, -- because I didn't know how it works.  And you're
> right, it's not a good change ;)  But your email come before I was
> able to reply.  Unqueued.

Hi, Michael

do you queued patch 1-3?
if so, I will only send one patch for comments from Andreas,
otherwise, I will refactor all patches.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]