[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to s

From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output
Date: Mon, 27 May 2013 11:55:11 -0400

On Mon, 27 May 2013 17:40:59 +0200
Kevin Wolf <address@hidden> wrote:

> Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben:
> > On Sat, 25 May 2013 11:09:45 +0800
> > Wenchao Xia <address@hidden> wrote:
> > 
> > > bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer 
> > > now,
> > > some internal buffers are still used for format control, which have no
> > > chance to be truncated. As a result, these two functions have no more 
> > > issue
> > > of truncation, and they can be used by both qemu and qemu-img with correct
> > > parameter specified.
> > > 
> > > Signed-off-by: Wenchao Xia <address@hidden>
> > 
> > I don't like the casting and the void pointers very much, but I can't
> > suggest anything better:
> Maybe introduce and use a different function pointer type that
> explicitly takes void* instead of FILE*. You'd still have to cast the
> function pointers (and now actually in all instances), but then at least
> nobody can accidentally misinterpret a Monitor* as FILE*.

I'm not sure this helps much because we'd have two functions pointers
to choose (which fails the purpose of having the function pointer IMO) and
also, there's code in QEMU doing this cast/void dance already.

If we want a good solution, we'd have to find a better way to print to
the monitor and to standard output.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]