[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for a

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64
Date: Mon, 27 May 2013 10:05:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

On 2013-05-27 02:10, Claudio Fontana wrote:
+    case INDEX_op_mov_i64: ext = 1;

Please don't put code on the same line as a case statement.
Also fall-through cases should have an explicit /* fall through */
comment (except in the case where there is no code at all
between one case statement and the next).

Would it be acceptable to put a comment at the beginning of the function
describing ext use, to avoiding a series of /* fall through */ comments?

Like this:

/* ext will be set in the switch below, which will fall through
    to the common code. It triggers the use of extended registers
    where appropriate. */

and then going:

case INDEX_op_something_64:
     ext = 1;
case INDEX_op_something_32:
     the_actual_meat(s, ext, ...);

I'll again suggest using the macro expansion that the i386 port uses.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]