[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i.MX: implement a more complete version of the

From: Peter Chubb
Subject: Re: [Qemu-devel] [PATCH] i.MX: implement a more complete version of the GPT timer.
Date: Tue, 28 May 2013 09:43:35 +1000
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj┼Ź) APEL/10.8 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

>>>>> "Jean-Christophe" == Jean-Christophe DUBOIS <address@hidden> writes:

Jean-Christophe> * implement compare 1 2 and 3 registers * Unify
Jean-Christophe> function and type naming * use dynamic cast whenever
Jean-Christophe> possible * simplify Debug printf.  * use new style
Jean-Christophe> device intialization.

Can you split this patch into two patches: one that just does the changes to
support the comparison registers, and one that adapts to the newstyle
device initialisation and has the cosmetic renamings and code
reorganisaiton, please? 

I'd much rather review them separately, and keep functional and
non-functional changes separate.

Dr Peter Chubb                                  peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA

reply via email to

[Prev in Thread] Current Thread [Next in Thread]