[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile |
Date: |
Tue, 28 May 2013 11:21:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 28/05/2013 11:12, Andreas Färber ha scritto:
> Am 28.05.2013 10:54, schrieb Paolo Bonzini:
>> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
>>> The symlink to "asm" platform linux headers is made in the build tree by
>>> the configure script but gcc is not told to look for them there.
>>>
>>> The patch fixes this.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>> ---
>>>
>>> The previous patch did not remove the old line adding includes. Early
>>> morning,
>>> lack of focus :)
>>>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 5ae7e4a..eca2a20 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -547,7 +547,7 @@ Haiku)
>>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>>> audio_possible_drivers="$audio_possible_drivers fmod"
>>> fi
>>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>>> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers
>>> $QEMU_INCLUDES"
>>> ;;
>>> esac
>>>
>>>
>>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>
> Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't
> this just be -Ilinux-headers?
I think -Ilinux-headers would add
<builddir>/x86_64-softmmu/linux-headers, which is wrong.
> And might it make sense to give the build directory precedence over the
> source directory?
It shouldn't matter.
Paolo
- [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Peter Maydell, 2013/05/27
- Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Paolo Bonzini, 2013/05/27
- Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- [Qemu-devel] [PATCH v2] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile, Alexey Kardashevskiy, 2013/05/27
- Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile, Paolo Bonzini, 2013/05/28
- Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile, Andreas Färber, 2013/05/28
- Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile, Anthony Liguori, 2013/05/29