[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] tests: set MALLOC_PERTURB_ to expose memory
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] tests: set MALLOC_PERTURB_ to expose memory bugs |
|
Date: |
Tue, 28 May 2013 06:31:57 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/27/2013 07:28 AM, Stefan Hajnoczi wrote:
> glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment
> variable is set. The value of the environment variable determines the
> bit pattern used to wipe memory. For more information, see
> http://udrepper.livejournal.com/11429.html.
>
> Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note we pick a random
> value from 1 to 255 to expose more bugs. If you need to reproduce a
> crash use 'show environment' in gdb to extract the MALLOC_PERTURB_
> value from a core dump.
>
> Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> Embarassing how long it's taking to get this right :P
But at least the code review process prevents your embarrassment from
being codified into qemu.git across multiple commits :)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature