Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

[Peter Maydell]

On 29 May 2013 09:18, David Gibson <address@hidden> wrote:
> On Mon, May 27, 2013 at 02:20:57PM +1000, address@hidden wrote:
>> From: Peter Crosthwaite <address@hidden>
>> Currently QEMU provides a local clone of the file libfdt_env.h in
>> /include. This file is supposed to come with the libfdt package and is
>
> So, this patch might be the right thing anyway, but the statement
> above is entirely false.  libfdt_env.h is explicitly intended to be
> supplied by the build environment embedding libfdt.  The version
> provided in the libfdt package is a example version which will do
> (although it might not be ideal) for userspace builds with a
> sufficiently normal C library.

(You're upstream for libfdt, yes?)

If you're expecting that build environments provide a libfdt_env.h
then shouldn't you be avoiding making breaking changes to libfdt
that require build environments to fix their libfdt_env.h?
This came up in the first place because we no longer build with
new libfdt...

(conversely, if we're supposed to update our libfdt_env.h as we
go along, is there a changelog that documents needed changes
and what needs to be present for compatibility with older versions
of libfdt?)

thanks
-- PMM