[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: add block driver read only whitelist
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3] block: add block driver read only whitelist |
Date: |
Wed, 29 May 2013 20:04:48 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 05/29 13:56, Kevin Wolf wrote:
> Am 29.05.2013 um 13:35 hat Fam Zheng geschrieben:
> > We may want to include a driver in the whitelist for read only tasks
> > such as diagnosing or exporting guest data (with libguestfs as a good
> > example). This patch introduces a readonly whitelist option, and for
> > backward compatibility, the old configure option --block-drv-whitelist
> > is now an alias to rw whitelist.
> >
> > Drivers in readonly list is only permitted to open file readonly, and
> > returns -ENOTSUP for RW opening.
> >
> > E.g. To include vmdk readonly, and others read+write:
> > ./configure --target-list=x86_64-softmmu \
> > --block-drv-rw-whitelist=qcow2,raw,file,qed \
> > --block-drv-ro-whitelist=vmdk
> >
> > v3:
> > Fix hw/block/xen_disk.c.
> >
> > v2:
> > Use a separate configure option, no more magic prefix.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block.c | 43 +++++++++++++++++++++++++++----------------
> > blockdev.c | 4 ++--
> > configure | 20 +++++++++++++++-----
> > hw/block/xen_disk.c | 8 ++++++--
> > include/block/block.h | 3 ++-
> > scripts/create_config | 11 +++++++++--
> > 6 files changed, 61 insertions(+), 28 deletions(-)
>
> Thanks, applied to the block branch.
>
> For future patches, please make sure to include the version history of
> the patch below the "---" line so that git am automatically drops it.
OK, thanks for teaching me this.
--
Fam