[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the mo

From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor
Date: Wed, 29 May 2013 13:51:01 -0400

On Wed, 29 May 2013 10:13:42 +0200
Kevin Wolf <address@hidden> wrote:

> Am 28.05.2013 um 18:07 hat Eric Blake geschrieben:
> > On 05/28/2013 09:27 AM, Kevin Wolf wrote:
> > > The QMP version is flagged with a __org.qemu.debug- prefix in order to
> > > reinforce the statement that qemu-io is for testing and debugging only,
> > > with no API guarantees.
> > 
> > Correct use of naming conventions.
> > 
> > Hmm, I wonder if the recent addition of an 'abort' action to
> > 'transaction' should be renamed __org.qemu.debug-abort, to make it
> > obvious that it is another case of a QMP command useful mainly for
> > testing, and not real-life use.
> Makes sense to me.
> But first I'd like to get Luiz's ack for this, because I think I'm the
> first one to use an __org.qemu prefix, and I'm the first one trying to
> introduce a QMP command without API stability.

I think that should be fine. However, it's not a perfect match for QMP
as you don't expect mngt to use it anytime soon and that the command's
syntax is not QMP friendly:

> { "execute": "__org.qemu.debug-qemu-io-command", "arguments":
>     { "device": "ide0-hd0", "command": "write -P 0x12 4M 512k" } }

What about adding a HMP-only command (the good old way) and use it
through human-monitor-command?

IMO, this matches better your current use-case and the API instability
of the command.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]