[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend ope
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations |
Date: |
Fri, 31 May 2013 12:13:52 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/31/2013 11:05 AM, Jani Kokkonen wrote:
> +static inline void tcg_out_uxt(TCGContext *s, int s_bits,
> + TCGReg rd, TCGReg rn)
> +{
> + /* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00
> + of UBFM Wd, Wn, #0, #7|15 and mov */
> + int bits = 8 * (1 << s_bits) - 1;
> + tcg_out_ubfm(s, 0, rd, rn, 0, bits);
> +}
Err, ubfm never generates mov, does it?
Yes, you do that later,
> + case INDEX_op_ext32u_i64:
> + tcg_out_movr(s, 0, args[0], args[1]);
> + break;
but the comment isn't actually correct in tcg_out_uxt, surely?
r~
- [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG tlb fast lookup, Jani Kokkonen, 2013/05/31
- [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement byte swap operations, Jani Kokkonen, 2013/05/31
- [Qemu-devel] [PATCH 1/4] tcg/aarch64: more low level ops in preparation of tlb, lookup, Jani Kokkonen, 2013/05/31
- [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path, Jani Kokkonen, 2013/05/31
- [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations, Jani Kokkonen, 2013/05/31
- Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations,
Richard Henderson <=