[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 00/13] curl: fix curl read
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v7 00/13] curl: fix curl read |
Date: |
Thu, 6 Jun 2013 14:25:46 +0800 |
CURL library API has changed, the current curl driver is not working with
current libcurl. It may or may not have worked with old libcurl, but currently,
when testing with apache http URL, it just hangs before fetching any data. The
problem is because the mismatch of our code and how libcurl wants to be used.
(man 3 curl_multi_socket_action, section 'TYPICAL USAGE')
- Step 3. We need timer to support libcurl timeout.
- Step 6. We'll call the right API function, replacing the deprecated.
- Step 5, 8. Manage socket properly (take actions on socket fd that are passed
into socket callback from libcurl)
This patch rewrites the use of API as well as the structure of internal states:
BDRVCURLState holds the pointer to curl multi interface (man 3
libcurl-multi), and 4 lists for internal states:
- CURLState holds state for libcurl connection (man 3 libcurl-easy)
- CURLSockInfo holds information for libcurl socket interface (man 3
curl_multi_socket_action).
- CURLDataCache holds the user data read from libcurl, it is in a list
ordered by access, the used cache is moved to list head on access, so
the tail element is freed first. BDRVCURLState.cache_quota is the
threshold to start freeing cache.
- CURLAIOCB holds ongoing aio information.
v7:
13: Added:
curl: change timeout to 30 seconds
v6:
05: Rename bs to s for BDRVCURLState.
06: Use int64_t for offsets.
Fix printf format string.
Move introducing of use_count to 07.
07: Drop explicit cast.
Use int64_t for offsets.
Use_count moved here.
08: Remove duplicated.
Move s->url = NULL to separate patch.
09: Fix while(0);
12: Added:
curl: set s->url to NULL after free.
Fam Zheng (12):
curl: introduce CURLSockInfo to BDRVCURLState.
curl: change magic number to sizeof
curl: change curl_multi_do to curl_fd_handler
curl: fix curl_open
curl: add timer to BDRVCURLState
curl: introduce CURLDataCache
curl: make use of CURLDataCache.
curl: use list to store CURLState
curl: add cache quota.
curl: introduce ssl_no_cert runtime option.
curl: set s->url to NULL after free.
curl: change timeout to 30 seconds
Richard W.M. Jones (1):
block/curl.c: Refuse to open the handle for writes.
block/curl.c | 568 +++++++++++++++++++++++++++++++++++++----------------------
1 file changed, 353 insertions(+), 215 deletions(-)
--
1.8.3
- [Qemu-devel] [PATCH v7 00/13] curl: fix curl read,
Fam Zheng <=
- [Qemu-devel] [PATCH v7 01/13] curl: introduce CURLSockInfo to BDRVCURLState., Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 02/13] curl: change magic number to sizeof, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 03/13] curl: change curl_multi_do to curl_fd_handler, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 04/13] curl: fix curl_open, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 05/13] curl: add timer to BDRVCURLState, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 06/13] curl: introduce CURLDataCache, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 07/13] curl: make use of CURLDataCache., Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 08/13] curl: use list to store CURLState, Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 09/13] curl: add cache quota., Fam Zheng, 2013/06/06
- [Qemu-devel] [PATCH v7 10/13] curl: introduce ssl_no_cert runtime option., Fam Zheng, 2013/06/06