[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor |
Date: |
Thu, 6 Jun 2013 11:46:02 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jun 05, 2013 at 02:19:25PM +0200, Kevin Wolf wrote:
> This is a prerequisite for some kind of tests. It involves reorganising the
> qemu-io code so that the command part can be separated and doesn't pollute the
> global namespace any more, so we can link it with qemu.
>
> v2:
> - Drop the QMP command, make it HMP only
> - Minor review comments like typos
>
> Kevin Wolf (16):
> qemu-io: Remove unused args_command
> cutils: Support 'P' and 'E' suffixes in strtosz()
> qemu-io: Make cvtnum() a wrapper around strtosz_suffix()
> qemu-io: Handle cvtnum() errors in 'alloc'
> qemu-io: Don't use global bs in command implementations
> qemu-io: Split off commands to qemu-io-cmds.c
> qemu-io: Factor out qemuio_command
> qemu-io: Move 'help' function
> qemu-io: Move 'quit' function
> qemu-io: Move qemu_strsep() to cutils.c
> qemu-io: Move functions for registering and running commands
> qemu-io: Move command_loop() and friends
> qemu-io: Move remaining helpers from cmd.c
> qemu-io: Interface cleanup
> qemu-io: Use the qemu version for -V
> Make qemu-io commands available in HMP
>
> Makefile | 2 +-
> Makefile.objs | 1 +
> cmd.c | 612 -------------
> cmd.h | 79 --
> hmp-commands.hx | 16 +
> hmp.c | 18 +
> hmp.h | 1 +
> include/qemu-common.h | 3 +
> include/qemu-io.h | 46 +
> monitor.c | 8 +-
> qemu-img.c | 10 +-
> qemu-io-cmds.c | 2118
> ++++++++++++++++++++++++++++++++++++++++++++
> qemu-io.c | 1990 ++++-------------------------------------
> tests/qemu-iotests/049.out | 8 +-
> util/cutils.c | 25 +
> 15 files changed, 2416 insertions(+), 2521 deletions(-)
> delete mode 100644 cmd.c
> delete mode 100644 cmd.h
> create mode 100644 include/qemu-io.h
> create mode 100644 qemu-io-cmds.c
>
> --
> 1.8.1.4
>
On IRC kwolf explained that he moved cmd.c into qemu-io-cmds.c since
there are no other users and cmd.c uses global state (it's not easily
reusable anyway). I'm happy with dropping cmd.c now.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
- [Qemu-devel] [PATCH v2 11/16] qemu-io: Move functions for registering and running commands, (continued)
- [Qemu-devel] [PATCH v2 11/16] qemu-io: Move functions for registering and running commands, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 13/16] qemu-io: Move remaining helpers from cmd.c, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 15/16] qemu-io: Use the qemu version for -V, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 14/16] qemu-io: Interface cleanup, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 07/16] qemu-io: Factor out qemuio_command, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 05/16] qemu-io: Don't use global bs in command implementations, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 09/16] qemu-io: Move 'quit' function, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 08/16] qemu-io: Move 'help' function, Kevin Wolf, 2013/06/05
- Re: [Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor,
Stefan Hajnoczi <=