[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] xilinx_axidma: Do not set DMA .notify to
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] xilinx_axidma: Do not set DMA .notify to NULL after notify |
Date: |
Mon, 10 Jun 2013 13:10:29 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jun 07, 2013 at 01:05:38PM +1000, address@hidden wrote:
> From: Wendy Liang <address@hidden>
>
> If a stream notify function is not ready, it may re-populate the notify call-
> back to indicate it should be re-polled later. This break in this usage, as
> immediately following the notify() call, .notify is set to NULL. reverse the
> ordering of the notify call and NULL assignment accordingly.
>
> [PC: Reworked commit message]
>
> Signed-off-by: Wendy Liang <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
Applied master, thanks Wendy and Peter.
ACK for stable.
Acked-by: Edgar E. Iglesias <address@hidden>
> ---
> hw/dma/xilinx_axidma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index 3a3ef8a..50054cf 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -514,8 +514,9 @@ static void axidma_write(void *opaque, hwaddr addr,
> break;
> }
> if (sid == 1 && d->notify) {
> - d->notify(d->notify_opaque);
> + StreamCanPushNotifyFn notifytmp = d->notify;
> d->notify = NULL;
> + notifytmp(d->notify_opaque);
> }
> stream_update_irq(s);
> }
> --
> 1.8.3.rc1.44.gb387c77.dirty
>