[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mappi
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook |
Date: |
Tue, 11 Jun 2013 18:03:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 11.06.2013 16:56, schrieb Luiz Capitulino:
> On Sun, 9 Jun 2013 18:10:38 +0200
> Andreas Färber <address@hidden> wrote:
>
>> Change error reporting from return value to Error argument.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> include/qom/cpu.h | 14 ++++++++++++++
>> include/sysemu/memory_mapping.h | 2 --
>> memory_mapping-stub.c | 6 ------
>> memory_mapping.c | 7 ++++---
>> qom/cpu.c | 16 ++++++++++++++++
>> target-i386/arch_memory_mapping.c | 12 +++++++-----
>> target-i386/cpu-qom.h | 3 +++
>> target-i386/cpu.c | 1 +
>> 8 files changed, 45 insertions(+), 16 deletions(-)
>>
>> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
>> index 1f70240..254be2e 100644
>> --- a/include/qom/cpu.h
>> +++ b/include/qom/cpu.h
[...]
>> @@ -148,6 +152,16 @@ struct CPUState {
>> bool cpu_paging_enabled(const CPUState *cpu);
>>
>> /**
>> + * @cpu: The CPU whose memory mappings are to be obtained.
>> + * @list: Where to write the memory mappings to.
>> + * @errp: Pointer for reporting an #Error.
>> + *
>> + * Returns: 0 if successful.
>> + */
>
> It turns void now, but you can add:
>
> Reviewed-by: Luiz Capitulino <address@hidden>
>
> When you respin.
Thanks, fixing up as follows:
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 254be2e..a5bb515 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -152,11 +152,10 @@ struct CPUState {
bool cpu_paging_enabled(const CPUState *cpu);
/**
+ * cpu_get_memory_mapping:
* @cpu: The CPU whose memory mappings are to be obtained.
* @list: Where to write the memory mappings to.
* @errp: Pointer for reporting an #Error.
- *
- * Returns: 0 if successful.
*/
void cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list,
Error **errp);
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-cpu v4 05/18] target-i386: Set level=4 on Conroe/Penryn/Nehalem, (continued)
- [Qemu-devel] [PATCH qom-cpu v4 05/18] target-i386: Set level=4 on Conroe/Penryn/Nehalem, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 08/18] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 07/18] cpu: Turn cpu_paging_enabled() into a CPUState hook, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 10/18] memory_mapping: Drop qemu_get_memory_mapping() stub, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 11/18] dump: Drop qmp_dump_guest_memory() stub and build for all targets, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 14/18] dump: Abstract dump_init() with cpu_synchronize_all_states(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu v4 15/18] dump: Abstract dump_init() further with qemu_for_each_cpu(), Andreas Färber, 2013/06/09