Re: [Qemu-devel] [Qemu-ppc] [PATCH 8/9] kvm/openpic: in-kernel mpic support

[Scott Wood]

On 06/12/2013 08:01:06 AM, Alexander Graf wrote:
> On 01.05.2013, at 03:48, Scott Wood wrote:
> > +static void kvm_openpic_region_add(MemoryListener *listener,
> > +                                   MemoryRegionSection *section)
> > +{
> > +    KVMOpenPICState *opp = container_of(listener, KVMOpenPICState,
> > +                                        mem_listener);
> > +    struct kvm_device_attr attr;
> > +    uint64_t reg_base;
> > +    int ret;
> > +
> > +    if (section->address_space != &address_space_memory) {
> > +        abort();
> > +    }
> > +
> > +    if (reg_base) {
>
> Check on uninitialized variable.

Oops, leftover debug code from when the code looked a bit different. :-P

I wonder why GCC (4.5) didn't warn about this.

-Scott