Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

[Alexey Kardashevskiy]

Fails on qtest_init() in tests/libqtest.c, "Broken pipe". I cannot easily
see what is wrong here with this patch but it is 100% reproducible on x86_64
 :(


On 06/13/2013 04:28 PM, Alexey Kardashevskiy wrote:
> Hi!
> 
> I do not know how (yet) but this patch breaks qtest on x86 (I bisected it):
> 
> 
> make check-qtest V=1
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k
> --verbose -m=quick tests/fdc-test tests/ide-test tests/hd-geo-test
> tests/rtc-test tests/i440fx-test tests/fw_cfg-test
> TEST: tests/fdc-test... (pid=13049)
> Broken pipe
> FAIL: tests/fdc-test
> TEST: tests/ide-test... (pid=13053)
>   /x86_64/ide/identify:
> Broken pipe
> FAIL
> GTester: last random seed: R02S2f8a8fd53ff256765db44cefb0a920ce
> (pid=13057)
>   /x86_64/ide/bmdma/setup:
> Broken pipe
> FAIL
> GTester: last random seed: R02S0cec5d222cfd196e6e839e06d7ddde89
> (pid=13061)
>   /x86_64/ide/bmdma/simple_rw:                                         FAIL
> GTester: last random seed: R02S46a30a1ccd33dc104919118330810a85
> (pid=13062)
>   /x86_64/ide/bmdma/short_prdt:                                        FAIL
> GTester: last random seed: R02S19fdcc95895b870371ed5ddcc8b77eda
> (pid=13063)
> 
> [...]
> 
> 
> On 06/04/2013 10:13 PM, Paolo Bonzini wrote:
>> Add ref/unref calls at the following places:
>>
>> - places where memory regions are stashed by a listener and
>>   used outside the BQL (including in Xen or KVM).
>>
>> - memory_region_find callsites
>>
>> - creation of aliases and containers (only the aliased/contained
>>   region gets a reference to avoid loops)
>>
>> - around calls to del_subregion/add_subregion, where the region
>>   could disappear after the first call
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  exec.c                                |  6 +++++-
>>  hw/core/loader.c                      |  1 +
>>  hw/display/exynos4210_fimd.c          |  6 ++++++
>>  hw/display/framebuffer.c              | 12 +++++++-----
>>  hw/i386/kvmvapic.c                    |  1 +
>>  hw/misc/vfio.c                        |  2 ++
>>  hw/virtio/dataplane/hostmem.c         |  7 +++++++
>>  hw/virtio/vhost.c                     |  2 ++
>>  hw/virtio/virtio-balloon.c            |  1 +
>>  hw/xen/xen_pt.c                       |  4 ++++
>>  include/hw/virtio/dataplane/hostmem.h |  1 +
>>  kvm-all.c                             |  2 ++
>>  memory.c                              | 20 ++++++++++++++++++++
>>  target-arm/kvm.c                      |  2 ++
>>  target-sparc/mmu_helper.c             |  1 +
>>  xen-all.c                             |  2 ++
>>  16 files changed, 64 insertions(+), 6 deletions(-)


-- 
Alexey