[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/5] memory: use '=' instead of '
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending |
Date: |
Tue, 18 Jun 2013 07:50:11 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 |
18.06.2013 06:32, li guang пишет:
> 在 2013-06-11二的 15:34 +0400,Michael Tokarev写道:
>> 11.06.2013 09:15, liguang wrote:
>>> because memory_region_update_pending is bool
>>>
>>> Signed-off-by: liguang <address@hidden>
>>> ---
>>> memory.c | 18 +++++++++---------
>>> 1 files changed, 9 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/memory.c b/memory.c
>>> index 5cb8f4a..d99eecd 100644
>>> --- a/memory.c
>>> +++ b/memory.c
>>> @@ -1114,7 +1114,7 @@ void memory_region_set_log(MemoryRegion *mr, bool
>>> log, unsigned client)
>>>
>>> memory_region_transaction_begin();
>>> mr->dirty_log_mask = (mr->dirty_log_mask & ~mask) | (log * mask);
>>> - memory_region_update_pending |= mr->enabled;
>>> + memory_region_update_pending = mr->enabled;
>>
>> This is wrong, and the original code was right. Here and in all other
>> places.
>
> Is it valid to do '|' operation for boolean?
Yes it is. Why do you think it might be problematic?
Thanks,
/mjt
[Qemu-devel] [PATCH 5/5] sd: pass bool parameter for sd_init, liguang, 2013/06/11
Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect, Andreas Färber, 2013/06/11
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect, Michael Tokarev, 2013/06/11