[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug |
Date: |
Thu, 27 Jun 2013 08:59:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 27/06/2013 04:08, liu ping fan ha scritto:
>> > qdev_free is triggered by the guest, but free is a misnomer. It is
>> > really "make it inaccessible from the guest and management" (the kernel
>> > equivalent would be removal of /dev and /sys entries, for example). The
>> > actual "free" will happen later.
>
> Without seeing your detail design, but I suggest that leaving the
> "exit" as it is, and pick out the inaccessible related code to
> removal.
We already have a reclamation point, it is instance_finalize.
I posted a series a few weeks ago ("[PATCH 00/39] Delay destruction of
memory regions to instance_finalize").
> Finally, when refcnt->0, exit is called, and it play as the
> final sync point for the remaining access.
It is the guest that determines when to start the removal phase. That's
qdev_free.
refcnt = 0 means that the memory is inaccessible to the guest, and
that's when the reclamation phase is started (asynchronously: the
instance_finalize callback is actually called at the end of the RCU
grace period).
Paolo
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, (continued)
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, Paolo Bonzini, 2013/06/25
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, liu ping fan, 2013/06/25
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, Paolo Bonzini, 2013/06/25
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, liu ping fan, 2013/06/25
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, liu ping fan, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, liu ping fan, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug, liu ping fan, 2013/06/26
- Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug,
Paolo Bonzini <=