[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH v6] add timestamp to error_report() |
|
Date: |
Mon, 8 Jul 2013 15:00:12 -0400 |
On Mon, 8 Jul 2013 18:47:24 +0000
Seiji Aguchi <address@hidden> wrote:
> > > +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
> > > + "-msg timestamp[=on|off]\n"
> > > + " change the format of messages\n"
> > > + " on|off controls leading timestamps (default:on)\n",
> >
> > Did you really intend to say it's on by default? Because it's actually
> > disabled by default. I prefer having this disabled btw, and I can fix it
> > myself before applying if that's what you intended.
>
>
> My default is "-msg timestamp".
> Why do you think it is actually disabled by default?
Oh, for some reason I assumed you wanted the timestamps to show up
even when -msg is not passed. But now I see that it's on by default
only if -msg timestamp is passed. Seems reasonable.
Applied to the qmp branch, thanks.