[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option |
Date: |
Mon, 08 Jul 2013 14:25:53 -0500 |
User-agent: |
Notmuch/0.15.2+202~g0c4b8aa (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Eric Blake <address@hidden> writes:
> On 07/05/2013 12:41 PM, Eduardo Habkost wrote:
>> On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote:
>>> From: Bandan Das <address@hidden>
>>>
>>> This allows us to use the "cpus" property multiple times
>>> to specify multiple cpu (ranges) to the -numa option :
>>>
>>> -numa node,cpus=1,cpus=2,cpus=4
>>> or
>>> -numa node,cpus=1-3,cpus=5
>>>
>>> Note that after this patch, the defalut suffix of "-numa node,mem=N"
>>> will no longer be "M". So we must add the suffix "M" like "-numa
>>> node,mem=NM"
>>> when assigning "N MB" of node memory size.
>>
>> Such an incompatible change is not acceptable, as it would break
>> existing configurations. libvirt doesn't specify any suffix and expects
>> it to always mean "MB".
>
> Newer libvirt can be taught to append 'M' when it detects it is talking
> to newer qemu. While you have a point that it is annoying to force
> users to upgrade to a newer libvirt merely because they upgraded qemu,
> the libvirt point of view is that the following are supported:
>
> old libvirt -> old qemu
> new libvirt -> old qemu
> new libvirt -> new qemu
>
> but that this combination is always best effort and not required to work:
>
> old libvirt -> new qemu
That's fine for libvirt, but we don't break command line compatibility
in QEMU. So this patch needs to change.
Regards,
Anthony Liguori
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
- [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/07/04
- [Qemu-devel] [PATCH V4 03/10] NUMA: Add Linux libnuma detection, Wanlong Gao, 2013/07/04
- [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option, Wanlong Gao, 2013/07/04
- Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option, Paolo Bonzini, 2013/07/14
- Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option, Eric Blake, 2013/07/15
- Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH V4 06/10] NUMA: split out the common range parser, Wanlong Gao, 2013/07/04
[Qemu-devel] [PATCH V4 02/10] NUMA: Add numa_info structure to contain numa nodes info, Wanlong Gao, 2013/07/04
[Qemu-devel] [PATCH V4 04/10] NUMA: parse guest numa nodes memory policy, Wanlong Gao, 2013/07/04