[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 repost 6/9] loader: support for unmapped ROM
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 repost 6/9] loader: support for unmapped ROM blobs |
Date: |
Mon, 15 Jul 2013 19:03:37 +0300 |
On Mon, Jul 15, 2013 at 03:22:33PM +0200, Laszlo Ersek wrote:
> On 07/10/13 15:51, Michael S. Tsirkin wrote:
>
> > @@ -697,7 +703,12 @@ static void rom_reset(void *unused)
> > if (rom->data == NULL) {
> > continue;
> > }
> > - cpu_physical_memory_write_rom(rom->addr, rom->data, rom->datasize);
> > + if (rom->mr) {
> > + void *host = memory_region_get_ram_ptr(rom->mr);
> > + memcpy(host, rom->data, rom->datasize);
> > + } else {
> > + cpu_physical_memory_write_rom(rom->addr, rom->data,
> > rom->datasize);
> > + }
> > if (rom->isrom) {
> > /* rom needs to be written only once */
> > g_free(rom->data);
>
> Can you please explain the difference?
>
> Thanks
> Laszlo
Could you please clarify the question?
If the ROM is not mapped into guest memory, it can't
be accessed with cpu_physical_memory_write_rom.
--
MST
- Re: [Qemu-devel] [PATCH v2 repost 5/9] i386: add bios linker/loader, (continued)
[Qemu-devel] [PATCH v2 repost 2/9] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/07/10
[Qemu-devel] [PATCH v2 repost 7/9] loader: allow adding ROMs in done callbacks, Michael S. Tsirkin, 2013/07/10
[Qemu-devel] [PATCH v2 repost 6/9] loader: support for unmapped ROM blobs, Michael S. Tsirkin, 2013/07/10
Re: [Qemu-devel] [PATCH v2 repost 6/9] loader: support for unmapped ROM blobs, Laszlo Ersek, 2013/07/17
[Qemu-devel] [PATCH v2 repost 9/9] i386: ACPI table generation code from seabios, Michael S. Tsirkin, 2013/07/10
[Qemu-devel] [PATCH v2 repost 4/9] acpi: pre-compiled ASL files, Michael S. Tsirkin, 2013/07/10
[Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info, Michael S. Tsirkin, 2013/07/10
Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info, Hu Tao, 2013/07/18