[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on c
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert |
Date: |
Tue, 16 Jul 2013 13:27:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 16/07/2013 13:18, Peter Lieven ha scritto:
>> Looks good. Perhaps, as a followup, you can use max_unmap (which I'd
>> rename to max_discard) in bdrv_co_discard to support splitting the
>> request. You could also export the discard alignment in BlockDriverInfo.
> I already did this in my previous series for iscsi.
> But I can also add a follow
> up if in the future another driver specifies max_discard. I will drop it
> from iscsi again then.
In general, I prefer to have things in the block layer if there is a
chance of them becoming generic. I guess in this case the chance is
relatively small.
On the other hand, if you add any smartness such as handling alignment
(see http://lkml.org/lkml/2012/7/5/342) please do take the occasion to
move it out of block/iscsi.c.
> Before this patch here is merged, we need the other series "[PATCHv3
> 00/10] iscsi/qemu-img/block-migration enhancements"
> otherwise patch 2/4 will not apply. Maybe you can put it together again
> or I will do a v4 with all patches together.
Perhaps. Both might also conflict with my get_block_status patches.
I'm going to send an updated version today. Ugh, it's already 1:30 PM. :(
Paolo
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, (continued)
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17