[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support |
Date: |
Tue, 16 Jul 2013 23:24:43 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 07/16/2013 10:48 PM, Alexey Kardashevskiy wrote:
> On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote:
>> On 07/16/2013 10:33 PM, Anthony Liguori wrote:
>>> Alexey Kardashevskiy <address@hidden> writes:
>>>
>>>> On 07/16/2013 01:11 AM, Anthony Liguori wrote:
>>>>> This series is based on Alexey's series:
>>>>>
>>>>> spapr: migration, pci, msi, power8
>>>>>
>>>>> Which in turn was based on work by David Gibson.
>>>>>
>>>>> I've removed the bits not related to migration and made the
>>>>> following changes:
>>>>>
>>>>> 1) QOMify TCE tables and XICS
>>>>>
>>>>> 2) Do everything in terms of VMStateDescriptions
>>>>>
>>>>> 3) Fix endianness problem with TCE table translation
>>>>> a) Drop the VMSTATE_DIVIDE thing in the process
>>>>>
>>>>> I've tested this with a TCG pseries guest on an x86_64 host.
>>>>
>>>>
>>>> It did not compile (fixed, patch is posted) and it fails to migrate with
>>>> enabled KVM.
>>>
>>> With in-kernel XICS? That's not in this series..
>>
>> No, as is, without any of my patches. I suspect rather HPTE than XICS though.
>
> I was wrong. vmstate_spapr_tce_table is broken :)
Here it is:
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index 709cc34..3d4a1fc 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -148,6 +148,7 @@ static int spapr_tce_table_realize(DeviceState *dev)
* sizeof(uint64_t);
tcet->table = g_malloc0(table_size);
}
+ tcet->nb_table = tcet->window_size >> SPAPR_TCE_PAGE_SHIFT;
#ifdef DEBUG_TCE
fprintf(stderr, "spapr_iommu: New TCE table @ %p, liobn=0x%x, "
Honestly, I liked David's approach more when we did not need any extra
parameter to sync :(
--
Alexey
- [Qemu-devel] [PATCH 02/11] pseries: savevm support for VIO devices, (continued)
- [Qemu-devel] [PATCH 02/11] pseries: savevm support for VIO devices, Anthony Liguori, 2013/07/15
- [Qemu-devel] [PATCH 03/11] pseries: savevm support for PAPR VIO logical lan, Anthony Liguori, 2013/07/15
- [Qemu-devel] [PATCH 11/11] xics: rename types to be sane and follow coding style, Anthony Liguori, 2013/07/15
- [Qemu-devel] [PATCH 08/11] pseries: savevm support for pseries machine, Anthony Liguori, 2013/07/15
- [Qemu-devel] [PATCH 09/11] pseries: savevm support for PCI host bridge, Anthony Liguori, 2013/07/15
- [Qemu-devel] [PATCH 10/11] pseries: savevm support with KVM, Anthony Liguori, 2013/07/15
- Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support, Alexey Kardashevskiy, 2013/07/16