Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

[Kevin Wolf]

Am 15.07.2013 um 12:49 hat Peter Lieven geschrieben:
> if a destination has has_zero_init = 0, but it supports
> discard zeroes use discard to convert the target
> into an all zero device.
> 
> Signed-off-by: Peter Lieven <address@hidden>

Wouldn't it be better to use bdrv_write_zeroes() and extend the
implementation of that to use discard internally in those block drivers
where it makes sense?

Because here you're not really discarding (i.e. don't care about the
sectors any more), but you want them to be zeroed.

Kevin