[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirr
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target |
Date: |
Wed, 17 Jul 2013 17:42:12 +0800 |
Signed-off-by: Fam Zheng <address@hidden>
---
block/backup.c | 3 ++-
block/mirror.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 16105d4..b82f601 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -294,7 +294,7 @@ static void coroutine_fn backup_run(void *opaque)
hbitmap_free(job->bitmap);
bdrv_iostatus_disable(target);
- bdrv_delete(target);
+ bdrv_unref(target, true);
block_job_completed(&job->common, ret);
}
@@ -332,6 +332,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState
*target,
return;
}
+ bdrv_ref(target, true);
job->on_source_error = on_source_error;
job->on_target_error = on_target_error;
job->target = target;
diff --git a/block/mirror.c b/block/mirror.c
index bed4a7e..decdedb 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -479,8 +479,7 @@ immediate_exit:
}
bdrv_swap(s->target, s->common.bs);
}
- bdrv_close(s->target);
- bdrv_delete(s->target);
+ bdrv_unref(s->target, true);
block_job_completed(&s->common, ret);
}
@@ -574,6 +573,7 @@ void mirror_start(BlockDriverState *bs, BlockDriverState
*target,
s->granularity = granularity;
s->buf_size = MAX(buf_size, granularity);
+ bdrv_ref(target, true);
bdrv_set_dirty_tracking(bs, granularity);
bdrv_set_enable_write_cache(s->target, true);
bdrv_set_on_error(s->target, on_target_error, on_target_error);
--
1.8.3.2
- Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard, (continued)
[Qemu-devel] [PATCH v2 02/11] block: use refcnt for bs->backing_hd and bs->file, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 03/11] block: use refcnt for drive_init/drive_uninit, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 04/11] block: use refcnt for device attach/detach, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 05/11] migration: omit drive ref as we have bdrv_ref now, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 06/11] xen_disk: simplify blk_disconnect with refcnt, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target,
Fam Zheng <=
[Qemu-devel] [PATCH v2 08/11] block: simplify bdrv_drop_intermediate, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 09/11] block: add assertion to check refcount before deleting, Fam Zheng, 2013/07/17
[Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Fam Zheng, 2013/07/17