[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on c
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert |
Date: |
Wed, 17 Jul 2013 19:01:02 +0200 |
Am 17.07.2013 um 16:53 schrieb Paolo Bonzini <address@hidden>:
> Il 17/07/2013 16:46, Peter Lieven ha scritto:
>>
>> Am 17.07.2013 um 16:26 schrieb Paolo Bonzini <address@hidden>:
>>
>>> Il 17/07/2013 16:18, Peter Lieven ha scritto:
>>>>>>>> That would be ok if the patches are merged first. Otherwise I could
>>>>>>>> ask Kevin
>>>>>>>> to merge my old series (except the iscsi_co_write_zeroes patch as there
>>>>>>>> obviously is still room for discussion and improvement) and you could
>>>>>>>> tweak
>>>>>>>> iscsi_co_is_allocated later?
>>>>>>
>>>>>> I'll look at your old series, I think the conflicts are relatively
>>>>>> trivial. But I think that this series must wait for 1.7.
>>>> Would it be an Option to merge it except for the iscsi_co_is_allocated and
>>>> the iscsi_co_write_zeroes patch. 3 of the Patches fix potential bugs.
>>>
>>> Yes, of course! And I think I can merge them via scsi/next, too. What
>>> patches are you thinking of exactly? Can you write the numbers?
>>
>> Mandatory:
>> [PATCHv3 07/10] iscsi: fix -ENOSPC in iscsi_create()
>> [PATCHv3 08/10] iscsi: factor out sector conversions
>> [PATCHv3 09/10] iscsi: remove support for misaligned nb_sectors in aio_readv
>> [PATCHv3 10/10] iscsi: assert that sectors are aligned to LUN blocksize
>
> Applied all to scsi-next (trivial conflict in patches 8 and 10, solved
> them myself---just be careful when rebasing).
>
>> Optional (non-conflicting patches):
>> [PATCHv3 01/10] iscsi: add logical block provisioning information to iscsilun
>> [PATCHv3 05/10] block: add bdrv_write_zeroes()
>> [PATCHv3 06/10] block/raw: add bdrv_co_write_zeroes
>
> 5 and 6 must go through Kevin. As to 1, I suspect if you redo discard
> along the lines we discussed today it would become heavily different, so
> I'd rather not take it too.
>
Patch 1 will be only slightly different. It will only copy a few more values to
iscsilun. its primary the inquiry code. I Would put the things we discussed in
a second patch. But if you dont want to pull iscsi_co_is_allocated for your
series its not needed. If you would like to have it in i can add the missing
values and send you a patch.
Peter
> Paolo
>
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, (continued)
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert,
Peter Lieven <=
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Stefan Hajnoczi, 2013/07/19