[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qc
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file() |
Date: |
Thu, 18 Jul 2013 13:32:01 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 07/15 05:42, Xu Wang wrote:
> Add backing file loop check before execute change backing file for
> qcow2 format.
>
> Signed-off-by: Xu Wang <address@hidden>
> ---
> block/qcow2.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 0eceefe..01bd7d5 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1195,6 +1195,12 @@ fail:
> static int qcow2_change_backing_file(BlockDriverState *bs,
> const char *backing_file, const char *backing_fmt)
> {
> + /* Check if loop exists in backing files chain after changed */
> + if (bdrv_backing_file_loop_check(bs->filename,
> + bs->drv ? bs->drv->format_name : NULL,
> + backing_file, backing_fmt)) {
> + return -EIO;
> + }
> pstrcpy(bs->backing_file, sizeof(bs->backing_file), backing_file ?: "");
> pstrcpy(bs->backing_format, sizeof(bs->backing_format), backing_fmt ?:
> "");
>
> --
> 1.8.1.4
>
I'm not sure this is needed, there's already loop check in block layer's
bdrv_change_backing_file(), which calls drv->bdrv_change_backing_file().
wouldn't this be redundant?
Thanks.
--
Fam
- [Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check, Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 1/7] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list(), Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 2/7] block: Add WIN32 platform support for backing_file_loop_check(), Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 3/7] block: Check infinite loop in bdrv_img_create(), Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 4/7] block: Add backing file loop check in change_backing_file(), Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init(), Xu Wang, 2013/07/15
- [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file(), Xu Wang, 2013/07/15
- Re: [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file(),
Fam Zheng <=
- [Qemu-devel] [PATCH V3 7/7] block: Add backing file loop check in qed_change_backing_file(), Xu Wang, 2013/07/15
- Re: [Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check, Fam Zheng, 2013/07/18