[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand |
|
Date: |
Thu, 18 Jul 2013 10:55:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 18/07/2013 09:25, Fam Zheng ha scritto:
>> > + /* Probe up to 1 G at a time. */
>> > + sector_num = (curr.start + curr.length) >> BDRV_SECTOR_BITS;
>> > + nsectors_left = DIV_ROUND_UP(length, BDRV_SECTOR_SIZE) -
>> > sector_num;
>> > + n = MAX(1 << (30 - BDRV_SECTOR_BITS), nsectors_left);
>> > + ret = get_block_status(bs, sector_num, &n, &depth);
> Am I misunderstanding here, n is at least 1G, but in your comment it's
> up to 1 G at a time?
>
You're right, it should be MIN.
Paolo
- Re: [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value, (continued)
Re: [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value, Eric Blake, 2013/07/19
[Qemu-devel] [PATCH v2 11/17] block: return get_block_status data and flags for formats, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 14/17] raw-posix: return get_block_status data and flags, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 16/17] block: add default get_block_status implementation for protocols, Paolo Bonzini, 2013/07/16
[Qemu-devel] [PATCH v2 17/17] block: look for zero blocks in bs->file, Paolo Bonzini, 2013/07/16