[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warnin
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning |
Date: |
Thu, 18 Jul 2013 10:09:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/18/2013 09:36 AM, Peter Maydell wrote:
> On 18 July 2013 17:14, Richard Henderson <address@hidden> wrote:
>> At -O2, code in the form
>>
>> if (p) A; B; if (p) C;
>>
>> may be rearranged via "jump threading" into
>>
>> if (p) { A; B; C; } else { B; }
>>
>> But at -O1 this doesn't happen and we -Werror out here on
>> the "may be used uninitialized" orig_len. Perform this transform
>> by hand so that -O1 remains a viable debugging alternative.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>
> This is the same issue fixed by this (reviewed but
> never applied) patch from June, isn't it?
>
> http://patchwork.ozlabs.org/patch/251410/
Yes, it is.
r~