[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors |
Date: |
Fri, 19 Jul 2013 07:05:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> qemu-img convert is assuming "that sectors which are unallocated in the input
> image are present in both the output's and input's base images", but it is
> only doing this if the output image is zero initialized. And checking if
> the output image is zero initialized does not make much sense if the
> output image is copy-on-write. Always do the test.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qemu-img.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents, (continued)
- [Qemu-devel] [PATCH v2 16/17] block: add default get_block_status implementation for protocols, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 17/17] block: look for zero blocks in bs->file, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 06/17] block: expect errors from bdrv_co_is_allocated, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors,
Eric Blake <=
- [Qemu-devel] [PATCH v2 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata, Eric Blake, 2013/07/16
Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata, Peter Lieven, 2013/07/18
Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata, Stefan Hajnoczi, 2013/07/19