[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. |
Date: |
Fri, 19 Jul 2013 13:41:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/19/2013 11:03 AM, Ian Main wrote:
> This patch adds sync-modes to the drive-backup interface and
> implements the FULL, NONE and TOP modes of synchronization.
>
> Signed-off-by: Ian Main <address@hidden>
> ---
> block/backup.c | 91
> +++++++++++++++++++++++++++++++----------------
> blockdev.c | 25 ++++++++-----
> include/block/block_int.h | 4 ++-
> qapi-schema.json | 4 +++
> qmp-commands.hx | 1 +
> 5 files changed, 86 insertions(+), 39 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -1807,6 +1807,10 @@
> # @format: #optional the format of the new destination, default is to
> # probe if @mode is 'existing', else the format of the source
> #
> +# @sync: what parts of the disk image should be copied to the destination
> +# (all the disk, only the sectors allocated in the topmost image, or
> +# only new I/O).
> +#
> # @mode: #optional whether and how QEMU should create a new image, default is
> # 'absolute-paths'.
> #
This hunk is still wrong. And we still haven't answered the
meta-question on whether @format should be mandatory (which I'd rather
fix that first, then rebase this on top of that).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V5 3/4] Add backing drive while performing backup., Ian Main, 2013/07/19
[Qemu-devel] [PATCH V5 4/4] Change default to qcow2 for sync mode none., Ian Main, 2013/07/19