Re: [Qemu-devel] [PATCHv2] [RFC 2/7] aio / timers: qemu-timer.c utility functions and add list of clocks

[Alex Bligh]

Richard,

--On 23 July 2013 13:09:18 -0800 Richard Henderson <address@hidden> wrote:

> On 07/20/2013 10:06 AM, Alex Bligh wrote:
> > +int64_t qemu_clock_deadline_ns(QEMUClock *clock);
> > +int64_t qemu_clock_deadline_all_ns(void);
> > +int qemu_timeout_ns_to_ms(int64_t ns);
> > +gint qemu_g_poll_ns(GPollFD *fds, guint nfds, int64_t timeout);
>
> Why continue with the g_ prefix here?  Surely qemu_poll_ns is sufficient.

Only because it was a g_ type function (takes GPollFD*, guint, and returns
gint). Quite happy to make it a qemu_poll_ns. Perhaps I should make it take
uint and return int at the same time.

TBH I am confused as to why we use g_poll at all. I thought originally
we were using it for win32, but that doesn't use g_poll. Given poll is
POSIX, what platforms do we target which are glib, !win32, and !posix?
Using straight posix would be easier.

--
Alex Bligh