[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling |
|
Date: |
Fri, 26 Jul 2013 12:43:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7 |
Hi,
> This also adds ohci_stop() call to ohci_bus_start() to handle possible
> failure of qemu_new_timer_ns().
> * ohci_stop renamed to ohci_die to describe the action better
Except in the commit message ...
Also scripts/checkpatch.pl complains:
ERROR: return is not a function, parentheses are not required
#90: FILE: hw/usb/hcd-ohci.c:590:
+ return (get_dwords(ohci, addr, (uint32_t *)td, 4) ||
ERROR: return is not a function, parentheses are not required
#109: FILE: hw/usb/hcd-ohci.c:622:
+ return (put_dwords(ohci, addr, (uint32_t *)td, 4) ||
We are almost there now ;)
cheers,
Gerd