[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro |
Date: |
Sun, 28 Jul 2013 11:57:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 28.07.2013 09:29, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/pci-host/piix.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 3908860..bf879e7 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -38,6 +38,10 @@
> * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> */
>
> +#define TYPE_I440FX_PCI_HOST "i440FX-pcihost"
> +#define I440FX_PCI_HOST(obj) \
> + OBJECT_CHECK(I440FXState, (obj), TYPE_I440FX_PCI_HOST)
Either Anthony or mst had insisted on PCI_HOST_BRIDGE rather than
PCI_HOST. Other than that looks good, thanks!
Andreas
> +
> typedef struct I440FXState {
> PCIHostState parent_obj;
> } I440FXState;
> @@ -257,7 +261,7 @@ static PCIBus *i440fx_common_init(const char *device_name,
> PCII440FXState *f;
> unsigned i;
>
> - dev = qdev_create(NULL, "i440FX-pcihost");
> + dev = qdev_create(NULL, TYPE_I440FX_PCI_HOST);
> s = PCI_HOST_BRIDGE(dev);
> b = pci_bus_new(dev, NULL, pci_address_space,
> address_space_io, 0, TYPE_PCI_BUS);
> @@ -661,7 +665,7 @@ static void i440fx_pcihost_class_init(ObjectClass *klass,
> void *data)
> }
>
> static const TypeInfo i440fx_pcihost_info = {
> - .name = "i440FX-pcihost",
> + .name = TYPE_I440FX_PCI_HOST,
> .parent = TYPE_PCI_HOST_BRIDGE,
> .instance_size = sizeof(I440FXState),
> .instance_init = i440fx_pcihost_initfn,
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h, Igor Mammedov, 2013/07/28
[Qemu-devel] [PATCH 3/6] utils: add range_size() wrapper, Igor Mammedov, 2013/07/28
[Qemu-devel] [PATCH 4/6] pc: replace i440fx_common_init() with i440fx_init() as it isn't used by anywhere else, Igor Mammedov, 2013/07/28