[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables |
Date: |
Mon, 29 Jul 2013 17:05:23 -0400 |
On Fri, 19 Jul 2013 04:57:51 -0600
Eric Blake <address@hidden> wrote:
> On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote:
> > The qmp_migrate method uses the 'blk' and 'inc' parameter without
> > checking if they're valid or not (they may be uninitialized if
> > command is received via QMP)
> >
> > Signed-off-by: Pawit Pornkitprasan <address@hidden>
> > ---
> > migration.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> However, wouldn't it be nice if we improved the qapi generator to
> guarantee a sane default value for optional parameters, even when
> has_value is false?
We could do that for bool and pointers, but this wouldn't help
integers and enums. Also, even if we had default values, I guess
I'd enforce a common idiom for handling optionals as this is also
a good practice for preventing bugs.
- [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Pawit Pornkitprasan, 2013/07/19
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Eric Blake, 2013/07/19
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Pawit Pornkitprasan, 2013/07/19
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Markus Armbruster, 2013/07/29
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Anthony Liguori, 2013/07/29
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Markus Armbruster, 2013/07/30
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Anthony Liguori, 2013/07/30
- Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Markus Armbruster, 2013/07/30
Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Orit Wasserman, 2013/07/22
Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables, Luiz Capitulino, 2013/07/29