Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

[Luiz Capitulino]

On Mon, 22 Jul 2013 23:23:29 +0200
Andreas Färber <address@hidden> wrote:

> Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> > Convert stderr messages calling error_get_pretty()
> > to error_report().
> > 
> > Timestamp is prepended by -msg timstamp option with it.
> > 
> > This is suggested by Luiz Capitulino.
> > 
> > http://marc.info/?l=qemu-devel&m=137331442628866&w=2
> > 
> > Signed-off-by: Seiji Aguchi <address@hidden>
> > ---
> >  arch_init.c                 |    4 ++--
> >  hw/char/serial.c            |    5 +++--
> >  hw/i386/pc.c                |    6 +++---
> >  qemu-char.c                 |    2 +-
> >  target-i386/cpu.c           |    2 +-
> >  target-ppc/translate_init.c |    3 ++-
> >  vl.c                        |    9 +++++----
> >  7 files changed, 17 insertions(+), 14 deletions(-)
> 
> How is this related to error_get_pretty()?

Yeah, we're converting fprintf(stderr,) calls to error_report() so that
error messages get a timestamp.

> And does error_report() expect a trailing \n or not? I would assume no,
> but spotted some in this patch.

Yes, already confirmed by Markus.