[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for Blo
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState |
Date: |
Tue, 30 Jul 2013 14:16:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 30.07.2013 09:52, schrieb Fam Zheng:
> Introduce bdrv_ref/bdrv_unref to manage the lifecycle of
> BlockDriverState. They are unused for now but will used to replace
> bdrv_delete() later.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 22 ++++++++++++++++++++++
> include/block/block.h | 2 ++
> include/block/block_int.h | 1 +
> 3 files changed, 25 insertions(+)
Didn't Kevin and Markus look into turning BlockDriverState into QOM
objects a while back? That would give you reference counting for free,
even atomic unlike this patch.
MemoryRegion resorted to reference counting on the owner object that was
added for the purpose.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 4/7] block: make bdrv_delete() static, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 7/7] nbd: use BlockDriverState refcnt, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 2/7] iscsi: use bdrv_new() instead of stack structure, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 1/7] vvfat: use bdrv_new() to allocate BlockDriverState, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 5/7] migration: omit drive ref as we have bdrv_ref now, Fam Zheng, 2013/07/30
- [Qemu-devel] [PATCH v2 6/7] xen_disk: simplify blk_disconnect with refcnt, Fam Zheng, 2013/07/30