[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads fr
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions" |
Date: |
Thu, 08 Aug 2013 17:27:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-08-08 17:23, Peter Maydell wrote:
> On 3 August 2013 09:31, Jan Kiszka <address@hidden> wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.
>>
>> The commit was wrong: We only return -1 on invalid accesses, not on
>> valid but unbacked ones. This broke various corner cases.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> This revert fixes the regression in the 'musicpal' board.
>
> Presumably these two patches should go into 1.6 since it is
> a regression fix... cc'ing Anthony.
>
> Reviewed-by: Peter Maydell <address@hidden>
Yes, for 1.6 definitely. Sorry, forgot the proper CCing/tagging.
Thanks,
Jan
signature.asc
Description: OpenPGP digital signature