qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target v


From: Alex Bligh
Subject: Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)
Date: Thu, 22 Aug 2013 20:46:08 +0100



--On 22 August 2013 21:30:41 +0200 Paolo Bonzini <address@hidden> wrote:

Also, this is the same as some HMP commands' "-n" option (live
snapshots, mirroring, backup) so I suggest to use that name.

You mean -n instead of -C? Sure I can do that, but is that
something you feel strongly about? I am aware there are a number
of people who have been using the patch with -C for some time.

I'll be fine if Stefan and Kevin override me, but yes, I think
consistency is important.  qemu-img has offline functionality equivalent
to block jobs, and it is useful to keep qemu-img subcommands as
consistent as possible between them and with the corresponding HMP
commands.  convert is the equivalent of the online mirroring block job.

I note -f in hmp means 'whole disk' whereas in qemu-img it means 'format'.
A quick scan suggests there are no other flags that do similar things.
So this would be the first flag that is consistent I think!

--
Alex Bligh



reply via email to

[Prev in Thread] Current Thread [Next in Thread]