[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects dep
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER |
Date: |
Mon, 26 Aug 2013 18:59:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 26/08/2013 16:41, Richard Henderson ha scritto:
> On 08/25/2013 03:58 PM, Ákos Kovács wrote:
>> Set CONFIG_CLIPPER as default for default-configs/alpha-softmmu.mak
>>
>> Signed-off-by: Ákos Kovács <address@hidden>
>> ---
>> default-configs/alpha-softmmu.mak | 2 ++
>> hw/alpha/Makefile.objs | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/alpha-softmmu.mak
>> b/default-configs/alpha-softmmu.mak
>> index bc07600..1e8bbff 100644
>> --- a/default-configs/alpha-softmmu.mak
>> +++ b/default-configs/alpha-softmmu.mak
>> @@ -15,3 +15,5 @@ CONFIG_IDE_CMD646=y
>> CONFIG_I8259=y
>> CONFIG_MC146818RTC=y
>> CONFIG_ISA_TESTDEV=y
>> +
>> +CONFIG_CLIPPER=y
>> diff --git a/hw/alpha/Makefile.objs b/hw/alpha/Makefile.objs
>> index 5c74275..0a6ade5 100644
>> --- a/hw/alpha/Makefile.objs
>> +++ b/hw/alpha/Makefile.objs
>> @@ -1 +1 @@
>> -obj-y += dp264.o pci.o typhoon.o
>> +obj-$(CONFIG_CLIPPER) += dp264.o pci.o typhoon.o
>>
>
> I don't understand the point of this. There is one alpha emulation;
> if you disable it you're left with a program that's not useful. So
> why the configuration for it at all?
I think this was just for consistency with other targets. Either this
patch can be left out completely, or the symbol can be made default on
and unchangeable by the user.
Paolo
- [Qemu-devel] [RFC PATCH 00/47] Describing patchset, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 01/47] rules.mak: New logical functions, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 03/47] default-configs/: CONFIG_GDBSTUB_XML removed, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 04/47] scripts/kconfig: kconfig-frontends submodule added, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 02/47] Makefile.target: CONFIG_NO_* variables removed, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 05/47] Makefile: Clone kconfig git submodule in Makefile, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER, Ákos Kovács, 2013/08/25
- Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER, Paolo Bonzini, 2013/08/26
- Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER, Peter Maydell, 2013/08/26
- Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER, Paolo Bonzini, 2013/08/27
[Qemu-devel] [PATCH 07/47] hw/arm/Makefile.objs: CONFIG_* created for each board, Ákos Kovács, 2013/08/25