[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, wi
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, without suffixes |
Date: |
Tue, 27 Aug 2013 16:01:15 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben:
> To produce same output while using "qemu-img create", opt->str
> should store pure digit, without suffixes.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> ---
> util/qemu-option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index b939e8a..861929d 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -675,6 +675,8 @@ static void qemu_opt_parse(QemuOpt *opt, Error **errp)
> break;
> case QEMU_OPT_SIZE:
> parse_option_size(opt->name, opt->str, &opt->value.uint, errp);
> + g_free((char *)opt->str);
> + opt->str = g_strdup(stringify(opt->value_uint));
This is wrong, stringify() is a macro at compile time. You get
"opt->value_uint" for any option here.
You're probably looking for g_strdup_printf().
Kevin
- [Qemu-devel] [PATCH V18 00/25] replace QEMUOptionParameter with QemuOpts parser, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 02/25] qemu-option: avoid duplication of default value in QemuOpts, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 03/25] qemu-option: create four QemuOptsList related functions, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 04/25] qemu-option: create some QemuOpts functons, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, without suffixes, Dong Xu Wang, 2013/08/13
- Re: [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, without suffixes,
Kevin Wolf <=
- [Qemu-devel] [PATCH V18 06/25] add interface to block, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 07/25] block: add QemuOpts support for cow.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 08/25] block: add QemuOpts support for gluster.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 09/25] block: add QemuOpts support for iscsi.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 10/25] block: add QemuOpts support for qcow.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 11/25] block: add QemuOpts support for qcow2.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 12/25] block: add QemuOpts support for qed.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 13/25] block: add QemuOpts support for raw-posix.c, Dong Xu Wang, 2013/08/13
- [Qemu-devel] [PATCH V18 14/25] block: add QemuOpts support for raw-win32.c, Dong Xu Wang, 2013/08/13