qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 17/21] docs, qapi: document qemu-img map


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 17/21] docs, qapi: document qemu-img map
Date: Thu, 29 Aug 2013 09:31:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 08/29/2013 08:00 AM, Paolo Bonzini wrote:
> Eric Blake also requested including the output in qapi-schema.json,
> so that it is published through the introspection mechanism.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qapi-schema.json | 29 +++++++++++++++++++++++++++++
>  qemu-img.texi    | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+)
> 
> +# @offset: if present, the image file stores the data for this range in
> +#          raw format at the given offset.
> +#
> +# Since 1.6

We missed that boat.  1.7 now.

> +##
> +{ 'type': 'BlockDeviceMapEntry',
> +  'data': { 'start': 'int', 'length': 'int', 'depth': 'int', 'zero': 'bool',
> +            'data': 'bool', '*offset': 'int' } }

Fix that, and you can add:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]